Skip to content

[O2B-1505] LHCfills beam duration filter #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graduta merged 55 commits into from
Jan 21, 2026
Merged

[O2B-1505] LHCfills beam duration filter #2035

graduta merged 55 commits into from
Jan 21, 2026
+479 −7

Conversation

@Houwie7000
Copy link
Collaborator

@Houwie7000 Houwie7000 commented Dec 2, 2025 •
edited by graduta
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Option to filter by beam duration has been added to the LHCfills-page filter.

Notable changes for developers:

Changes made to the database:

@Houwie7000 Houwie7000 requested a review from isaachilly December 2, 2025 16:57
@Houwie7000 Houwie7000 self-assigned this Dec 2, 2025
@Houwie7000 Houwie7000 added frontend backend javascript Pull requests that update Javascript code labels Dec 2, 2025
@Houwie7000
Copy link
Collaborator Author

Houwie7000 commented Dec 4, 2025 •
edited
Loading

Git borked, it seems that it included changes from the previous task in this one...
Edit: fixed

@Houwie7000 Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 56e5c6a to 847d092 Compare December 8, 2025 13:10
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 23dbb7b to 11c1f9d Compare December 8, 2025 14:15
@codecov
Copy link

codecov bot commented Dec 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.58%. Comparing base (75d9853) to head (191fd52).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ilters/common/filters/TextComparisonFilterModel.js 0.00% 18 Missing ⚠️
...nents/Filters/LhcFillsFilter/beamDurationFilter.js 0.00% 4 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 4 Missing ⚠️
...components/Filters/common/filters/rawTextFilter.js 0.00% 1 Missing ⚠️
lib/public/views/Home/Overview/HomePageModel.js 0.00% 1 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 1 Missing ⚠️
lib/utilities/validateTime.js 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   45.60%   45.58%   -0.02%     
==========================================
  Files        1028     1031       +3     
  Lines       17134    17172      +38     
  Branches     3120     3123       +3     
==========================================
+ Hits         7814     7828      +14     
- Misses       9320     9344      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000 Houwie7000 marked this pull request as ready for review December 8, 2025 15:23
@Houwie7000 Houwie7000 requested a review from graduta as a code owner December 8, 2025 15:23
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 847d092 to 3110c29 Compare December 11, 2025 11:12
isaachilly
isaachilly reviewed Dec 16, 2025
View reviewed changes
Base automatically changed from feature/O2B-1503/lhcfills-fill-numbers-filter to main December 18, 2025 12:51
@Houwie7000
Copy link
Collaborator Author

Houwie7000 commented Dec 18, 2025 •
edited
Loading

Fixing broken tests WIP.....
Result: it was a fluke...

@Houwie7000
Copy link
Collaborator Author

Houwie7000 commented Jan 12, 2026

NOTE: 1503 slipped a bit of wrong JSDoc through, lib/utilities/rangeUtils.js LN 47 should indicate an array of strings not string. I'll push a commit here to fix it

graduta
graduta requested changes Jan 20, 2026
View reviewed changes
@graduta
Copy link
Member

graduta commented Jan 20, 2026

It would be great if you could also add some tests for the API /test/lhcFills to ensure API validation for JOI works as expected together with the server

isaachilly
isaachilly reviewed Jan 20, 2026
View reviewed changes
graduta
graduta previously approved these changes Jan 21, 2026
View reviewed changes
@graduta graduta merged commit 5fd8dba into main Jan 21, 2026
22 of 24 checks passed
@graduta graduta deleted the feature/O2B-1505/lhcfills-beam-duration-filter branch January 21, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

@isaachilly isaachilly isaachilly approved these changes

Assignees

@Houwie7000 Houwie7000

Labels

backend frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Houwie7000 @graduta @isaachilly